Skip to content

CPP-2161 parallel tasks #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apaleslimghost merged 20 commits into from
Aug 11, 2025
Merged

CPP-2161 parallel tasks #679

apaleslimghost merged 20 commits into from
Aug 11, 2025

Conversation

@apaleslimghost
Copy link
Member

@apaleslimghost apaleslimghost commented Jul 30, 2024 •
edited
Loading

implements parallel task running in userland using a task with options, which looks like:

commands:
  run:local:
    - Parallel:
        tasks:
          - Node:
              entry: server/index.js
          - Webpack:
              watch: true

also includes some refactoring to the core that was necessary to get this working, and some refactoring that turned out not to be necessary.

@apaleslimghost apaleslimghost requested a review from a team as a code owner July 30, 2024 10:52
@apaleslimghost apaleslimghost marked this pull request as draft July 30, 2024 10:53
Base automatically changed from split-config-loading to main October 1, 2024 14:55
@apaleslimghost apaleslimghost force-pushed the parallel branch 3 times, most recently from 9dc9c54 to 58d9ae1 Compare June 30, 2025 11:58
@apaleslimghost apaleslimghost marked this pull request as ready for review July 1, 2025 15:29
apaleslimghost
apaleslimghost commented Jul 1, 2025
View reviewed changes
@apaleslimghost apaleslimghost changed the title CPP-2161 proof of concept parallel tasks CPP-2161 parallel tasks Jul 1, 2025
olusoladavid
olusoladavid reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

@olusoladavid olusoladavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Haven't had the chance to fully test the new UX but the code approach is solid 🔥 . Thanks for putting together. I added some questions in the meantime

@apaleslimghost apaleslimghost force-pushed the parallel branch 2 times, most recently from 109c49d to 4ddcf74 Compare July 8, 2025 11:53
olusoladavid
olusoladavid approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@olusoladavid olusoladavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sheer brilliance; thank you - there's the DX edge case I mentioned but I wouldn't consider it blocking for an initial rollout of this feature

@apaleslimghost apaleslimghost mentioned this pull request Jul 15, 2025
Open
apaleslimghost and others added 10 commits August 11, 2025 17:36
@apaleslimghost
feat(parallel): configurable stopOnError behaviour
822baba
@apaleslimghost
feat: implement stop method for Parallel itself
7b22727 
just in case someone does something cursed with nested Parallel
@apaleslimghost
refactor: rename stopOnError to onError and change to a literal union
2af96cb 
so we can expand the possible values later
@apaleslimghost
test: add basic tests for Parallel task running things in parallel
5914c31
@apaleslimghost
test: use custom snapshot serialisers for all jest tests
11cb518
@apaleslimghost
test: add tests for parallel error handling
decd40c
@apaleslimghost @olusoladavid
docs(parallel): explain default sequential behaviour
3ea9a6d 
Co-authored-by: Olusola Oguntimehin <30433120+olusoladavid@users.noreply.github.com>
@apaleslimghost
refactor: mark config in loadTasks as ReadonlyDeep
5b4df83
@apaleslimghost
docs: remove outdated parallel explanation
2cd8c06
@apaleslimghost
docs: document when to implement task stop method
6707b7a
@apaleslimghost apaleslimghost enabled auto-merge (rebase) August 11, 2025 16:38
@apaleslimghost apaleslimghost merged commit 967ba8f into main Aug 11, 2025
15 of 16 checks passed
@apaleslimghost apaleslimghost deleted the parallel branch August 11, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olusoladavid olusoladavid olusoladavid approved these changes

@ft-dependency-auto-merger ft-dependency-auto-merger Awaiting requested review from ft-dependency-auto-merger ft-dependency-auto-merger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apaleslimghost @olusoladavid